Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IRSA enabled by default #1849

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Feb 6, 2022

Description

  • Enable IRSA by default

Motivation and Context

  • Within the EKS ecosystem, it is difficult to find a scenario where the EKS OIDC provider (IRSA) should not be enabled

Breaking Changes

  • No - users who wish to opt out of IRSA enablement can set enable_irsa = false

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@bryantbiggs bryantbiggs changed the title feat: enable IRSA by default feat: IRSA enabled by default Feb 6, 2022
@antonbabenko antonbabenko merged commit 21c3802 into terraform-aws-modules:master Feb 6, 2022
antonbabenko pushed a commit that referenced this pull request Feb 6, 2022
## [18.4.0](v18.3.1...v18.4.0) (2022-02-06)

### Features

* enable IRSA by default ([#1849](#1849)) ([21c3802](21c3802))
@antonbabenko
Copy link
Member

This PR is included in version 18.4.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants