Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the default launch_template_id to null for Managed Node Groups #1088

Merged
merged 4 commits into from
Nov 7, 2020

Conversation

barryib
Copy link
Member

@barryib barryib commented Nov 5, 2020

PR o'clock

Description

We should define launch_template_id for managed node groups only if it needed.

Resolves #1087

Checklist

BARRY Thierno Ibrahima (Canal Plus Prestataire) and others added 2 commits November 6, 2020 09:00
@barryib barryib added this to the v13.2.0 milestone Nov 7, 2020
@barryib barryib changed the title fix: Change the default launch_template_id to null for managed node groups fix: Change the default launch_template_id to null for managed node groups Nov 7, 2020
@barryib barryib changed the title fix: Change the default launch_template_id to null for managed node groups fix: Change the default launch_template_id to null for Managed Node Groups Nov 7, 2020
@barryib barryib merged commit 571da60 into terraform-aws-modules:master Nov 7, 2020
@barryib barryib deleted the tba/fix-1087 branch November 7, 2020 21:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading from 12.2.0 to 13.1.0 causes managed node groups to be rebuilt.
1 participant