Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update TLS provider and remove unnecessary cloud init version requirements #1966

Merged
merged 3 commits into from
Mar 25, 2022
Merged

feat: Update TLS provider and remove unnecessary cloud init version requirements #1966

merged 3 commits into from
Mar 25, 2022

Conversation

bryantbiggs
Copy link
Member

Description

  • Update TLS provider to require at least v3.0; there are no code changes required for this
  • Remove unnecessary cloud init version requirements in the EKS managed node group and self managed node group modules; the version is constrained in the user data module which both of those module use, rendering their requirements redundant

Motivation and Context

  • Keep providers up to date and clean up redundant requirements

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    • Tested on eks-managed-node-group example

@bryantbiggs bryantbiggs marked this pull request as ready for review March 24, 2022 19:21
bryantbiggs
bryantbiggs commented Mar 24, 2022
View reviewed changes
examples/eks_managed_node_group/main.tf
@@ -568,11 +568,6 @@ resource "aws_launch_template" "external" {
enabled = true
}

network_interfaces {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this example started complaining about setting a device index so just removing since its not required for the example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in the AWS provider about it - hashicorp/terraform-provider-aws#23766

We hit it in one of the projects but I don't remember the resolution (probably downgraded version). Maybe leave a comment around this section with the link to the issue, so we know what was it in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good to know - thought I was losing it 😅

Added back the block but commented it out with a link to the issue - bf45e14

@antonbabenko antonbabenko merged commit 0269d38 into terraform-aws-modules:master Mar 25, 2022
antonbabenko pushed a commit that referenced this pull request Mar 25, 2022
@semantic-release-bot
chore(release): version 18.15.0 [skip ci]
4898bf3 
## [18.15.0](v18.14.1...v18.15.0) (2022-03-25)

### Features

* Update TLS provider and remove unnecessary cloud init version requirements ([#1966](#1966)) ([0269d38](0269d38))
@antonbabenko
Copy link
Member

This PR is included in version 18.15.0 🎉

@bryantbiggs bryantbiggs deleted the feat/update-tls-provider branch March 25, 2022 10:56
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
@bryantbiggs @spr-mweber3
feat: Update TLS provider and remove unnecessary cloud init version r…
6856c4a 
…equirements (terraform-aws-modules#1966)
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
@semantic-release-bot @spr-mweber3
chore(release): version 18.15.0 [skip ci]
7f1ce1a 
## [18.15.0](terraform-aws-modules/terraform-aws-eks@v18.14.1...v18.15.0) (2022-03-25)

### Features

* Update TLS provider and remove unnecessary cloud init version requirements ([terraform-aws-modules#1966](terraform-aws-modules#1966)) ([0269d38](terraform-aws-modules@0269d38))
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
@bryantbiggs @it-without-politics
feat: Update TLS provider and remove unnecessary cloud init version r…
6dd97a5 
…equirements (terraform-aws-modules#1966)
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
@semantic-release-bot @it-without-politics
chore(release): version 18.15.0 [skip ci]
a94e3ae 
## [18.15.0](terraform-aws-modules/terraform-aws-eks@v18.14.1...v18.15.0) (2022-03-25)

### Features

* Update TLS provider and remove unnecessary cloud init version requirements ([terraform-aws-modules#1966](terraform-aws-modules#1966)) ([0269d38](terraform-aws-modules@0269d38))
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
@baibailiha @semantic-release-bot
chore(release): version 18.15.0 [skip ci]
260b4db 
## [18.15.0](terraform-aws-modules/terraform-aws-eks@v18.14.1...v18.15.0) (2022-03-25)

### Features

* Update TLS provider and remove unnecessary cloud init version requirements ([#1966](terraform-aws-modules/terraform-aws-eks#1966)) ([38fdcb0](terraform-aws-modules/terraform-aws-eks@38fdcb0))
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @antonbabenko