feat: Added support for client.authentication.k8s.io/v1beta1

[vsamidurai]

PR o'clock

Description

• Make kubeconfig_api_version configurable in templates kubeconfig.tpl

Please explain the changes you made here and link to any relevant issues.

Recently aws-cli switched to client.authentication.k8s.io/v1beta from v1alpha1 and reverted back to v1alpha1. So this PR makes kubeconfig API version configurable to support Kubernetes v1.22.

aws/aws-cli#6309

#1526

Checklist

• [ ☑] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[daroga0002]

background around this documented here #1526

[daroga0002]

@vsamidurai do you think this should be variable?
I have a mixed feeling here as most probably this variable will be never customised and is increasing a module inputs complexity. I would rather opt to change this permanently in template and not use variable for this.

With k8s 1.22 variable will need to be always changed to beta api so we will not avoid a impacting change which will happen sooner or later.

I think as of now this can be just parked for a while and merged when there will be other change modifying a launch configuration to release together.

[daroga0002]

resolves #1526

[stale]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

[antonbabenko]

@daroga0002 Should we merge this one? If yes, we need to fix the formatting and rebase it.

[vsamidurai]

@vsamidurai do you think this should be variable? I have a mixed feeling here as most probably this variable will be never customised and is increasing a module inputs complexity. I would rather opt to change this permanently in template and not use variable for this.

With k8s 1.22 variable will need to be always changed to beta api so we will not avoid a impacting change which will happen sooner or later.

I think as of now this can be just parked for a while and merged when there will be other change modifying a launch configuration to release together.

I thought this change may block, incase if anyone wants to use the earlier version of k8s with the old version of aws-cli. If you think the new version terraform-eks only supports clusters above 1.22 we can use hardcoded values than the optional parameters.

[vsamidurai]

@daroga0002 Should we merge this one? If yes, we need to fix the formatting and rebase it.

rebased and formatted PR.

[daroga0002]

I will review this PR and test soon

Some usefull link to understand also issue is kubernetes-sigs/aws-iam-authenticator@0221afb#diff-b03d5162238d36a569ac0c110484bf356f617e22967aeb1af853b02993da60b8

[daroga0002]

@vsamidurai thank you for contribution 🎉

I have tested and this is working:

$ diff kubeconfig_lt_with_mng-xunVNPIS kubeconfig_lt_with_mng-xunVNPIS_test
23c23
<       apiVersion: client.authentication.k8s.io/v1beta1
---
>       apiVersion: client.authentication.k8s.io/v1alpha1

so we can merge this.

[daroga0002]

@antonbabenko lets merge this to master

[antonbabenko]

@vsamidurai Please fix the failing checks before the merge. I have fixed it.

[antonbabenko]

Here we go! 🎉

v17.23.0 has been just released.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.