Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[customizations/eks]: Update credential API version" #6309

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Revert "[customizations/eks]: Update credential API version" #6309

merged 2 commits into from
Jul 30, 2021

Conversation

nateprewitt
Copy link
Member

Reverts #6289 in response to #6308. This will migrate back to the previous usage of the v1alpha1 endpoint

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #6309 (bcd7051) into develop (ff7a406) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6309   +/-   ##
========================================
  Coverage    92.81%   92.81%           
========================================
  Files          204      204           
  Lines        16201    16201           
========================================
  Hits         15037    15037           
  Misses        1164     1164
Impacted Files Coverage Δ
awscli/customizations/eks/get_token.py 100.00% <ø> (ø)
awscli/customizations/eks/update_kubeconfig.py 97.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7a406...bcd7051. Read the comment docs.

@nateprewitt nateprewitt force-pushed the revert-6289-eks-get-token-update branch from de42d05 to bcd7051 Compare July 30, 2021 22:51
kyleknap
kyleknap approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nateprewitt nateprewitt merged commit d754599 into develop Jul 30, 2021
@nateprewitt nateprewitt deleted the revert-6289-eks-get-token-update branch July 30, 2021 23:08
nateprewitt added a commit that referenced this pull request Jul 30, 2021
@nateprewitt
Revert "[customizations/eks]: Update credential API version" (#6309)
5cda586
nateprewitt added a commit that referenced this pull request Jul 30, 2021
@nateprewitt
Revert "[customizations/eks]: Update credential API version" (#6309)
c0a4f09
@nateprewitt nateprewitt mentioned this pull request Jul 30, 2021
Merged
@kdaily kdaily mentioned this pull request Jul 30, 2021
Closed
2 tasks
nateprewitt added a commit that referenced this pull request Jul 30, 2021
@nateprewitt
Revert "[customizations/eks]: Update credential API version" (#6309) (#…
cf16bd0 
…6310)
aws-sdk-python-automation added a commit that referenced this pull request Aug 2, 2021
@aws-sdk-python-automation
Merge branch 'release-1.20.12'
9ade39a 
* release-1.20.12:
  Bumping version to 1.20.12
  Update changelog based on model updates
  Revert "[customizations/eks]: Update credential API version" (#6309)
  refactored code block (#6307)
@tei-k tei-k mentioned this pull request Aug 5, 2021
Merged
This was referenced Aug 26, 2021
Closed
Merged
@micahhausler micahhausler mentioned this pull request Oct 13, 2021
Merged
@z0rc z0rc mentioned this pull request Nov 16, 2021
Closed
godd9170 pushed a commit to godd9170/aws-cli that referenced this pull request Mar 7, 2023
@nateprewitt @godd9170
Revert "[customizations/eks]: Update credential API version" (aws#6309)
9a81494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleknap kyleknap kyleknap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nateprewitt @codecov-commenter @kyleknap