Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ecr:GetAuthorizationToken for private ECR with Docker capabilities #12

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

good92
Copy link
Contributor

@good92 good92 commented Oct 31, 2022

Fixed private ECR policy to allow Docker capabilities.
Could be improved with an input variable for docker_capability activation.

Description

Added ecr:GetAuthorizationToken policy for private ECR with Docker capabilities

Motivation and Context

Using the ECR as private with as Docker (OCI) registry.

Breaking Changes

Adds a not needed policy for the private ECR when not used for Docker.

How Has This Been Tested?

Ongoing

Fixed private ECR policy to allow Docker capabilities.
Could be improved with an input variable for docker_capability activation.
@good92 good92 changed the title Added ecr:GetAuthorizationToken for private ECR with Docker capabilities feat Added ecr:GetAuthorizationToken for private ECR with Docker capabilities Oct 31, 2022
@antonbabenko antonbabenko changed the title feat Added ecr:GetAuthorizationToken for private ECR with Docker capabilities feat: Added ecr:GetAuthorizationToken for private ECR with Docker capabilities Oct 31, 2022
@antonbabenko antonbabenko merged commit 0a087ca into terraform-aws-modules:master Oct 31, 2022
antonbabenko pushed a commit that referenced this pull request Oct 31, 2022
## [1.5.0](v1.4.0...v1.5.0) (2022-10-31)

### Features

* Added ecr:GetAuthorizationToken for private ECR with Docker capabilities ([#12](#12)) ([0a087ca](0a087ca))
@antonbabenko
Copy link
Member

This PR is included in version 1.5.0 🎉

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants