Upgrade to 0.12 syntax

[fearoffish]

This upgrade handles the syntax change to terraform 0.12 syntax. I'm only using this to create single instance calls at the moment though, with no use of count.

[yasn77]

@fearoffish Looks like you beat me to it 😸

I just opened #91. I am happy to close my PR, although I would suggest removing the TODO comments as I feel they are not needed

[fearoffish]

Good point. I'll remove the TODO comments. I'm not sure if the comment about this issue is resolved though. Following the thread it looks like it, but this PR isn't the place to remove that.

[rparsonsbb]

Every coalescelist that returns only empty tuples will Error until 0.12.1 re: hashicorp/terraform#21370

temporary workaround is to provide a bogus [""] at the end of each coalescelist in outputs.tf

[den-is]

tested, in my prod, works great with additional fix mentioned by @rparsonsbb

[fearoffish]

@rparsonsbb @den-is Thanks for that, I've added the fix.

[heisian]

@antonbabenko can this get some attention?

@fearoffish I noticed the outputs from this module are lists within lists. i.e.,

Outputs:

id = [
  [
    "i-048620cxxx",
    "i-0e361f9bxxx",
    "i-0bbb8cexxx",
    "i-034792bxxx",
    "i-060f929xxx",
  ],
]

Is this intended? I modified the outputs file like so, so that all outputs are a non-nested list, i.e.:

Outputs:

id = [
  "i-048620cxxx",                                                                                                                                    
  "i-0e361f9bxxx",                                                                                                                                                    
  "i-0bbb8cexxx",                                                                                                                                    
  "i-034792bxxx",                                                                                                                                              
  "i-060f929xxx",                                                                                                                                                                                                                                                                                                      
]

To me, my modified version makes more sense, but I also just started terraforming in 0.12, so I don't have the full context of the original behavior of this module.

[antonbabenko]

Thanks, @fearoffish @den-is @rparsonsbb @heisian @yasn77 and everyone involved in one way or another!

v2.0.0 has been just released.

Remember to pin module version to be ~> v1.0 if you are using Terraform 0.11, and use ~> 2.0 if you are using Terraform 0.12.

Please give this release a try and open an issue if there is something wrong.

[heisian]

works! thank you @antonbabenko !

[fearoffish]

Thanks @antonbabenko!

[antonbabenko]

You are welcome!

[Amdingo]

Awesome works great thanks all!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.