feat: Add support for ASG maintenance_options and LT instance_requirements
#193
Conversation
examples/complete/main.tf
Outdated
| module "instance_requirements" { | ||
| source = "../../" | ||
|
|
||
| # Needs https://github.com/hashicorp/terraform-provider-aws/issues/21566 for ASG |
There was a problem hiding this comment.
Can we have a special/searchable phrase to know that something is blocked by by certain issue upstream? In some projects (not Terraform), I sometimes use @ref or @seealso to be able to search across the whole codebase. In Terraform I usually use @todo: Fix this or that.
WDYT?
There was a problem hiding this comment.
Yes, good point https://github.com/search?q=org%3Aterraform-aws-modules+TODO&type=code
Let me add that
| } | ||
| } | ||
|
|
||
| dynamic "memory_mib" { |
There was a problem hiding this comment.
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#memory_mib - this block is marked as required in the docs. Same as min.
There was a problem hiding this comment.
Oof, missed that. let me update
| } | ||
| } | ||
|
|
||
| dynamic "vcpu_count" { |
There was a problem hiding this comment.
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#vcpu_count - also should be required (according to the docs), same as min.
## [6.4.0](v6.3.0...v6.4.0) (2022-05-16) ### Features * Add support for ASG `maintenance_options` and LT `instance_requirements` ([#193](#193)) ([1d1d3c0](1d1d3c0))
|
This PR is included in version 6.4.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
maintenance_optionsinstance_requirements. This works as intended for the launch template, but additional provider updates are needed for this to integrate and work with autoscaling group Support Auto Scaling groups Attribute-Based Instance Type Selection for EC2 Auto Scaling (aws_autoscaling_group) and EC2 Fleet (aws_spot_fleet_request) hashicorp/terraform-provider-aws#21566Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request