-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create route53 records for SAN domains #1
Comments
I've just released v1.2.0 where multiple route53 records are created. This should fix the problem you are facing, but I could not properly test it. This module is almost identical now to this blog post - https://manicminer.io/posts/terraform-aws-acm-certificates-for-multiple-domains/ by @manicminer |
@antonbabenko Incidentally, I just added support for multiple zones to my module in case you're interested (it is somewhat hacky in true Terraform fashion) |
Looks nice. Thanks for sharing! |
@antonbabenko Note sure if this was an unintended side effort of the 1.2.0 fix mentioned above, but it looks like there is regression for a certificate request with an identical route53 entry, such as:
The error generated in 1.2.0 as it attempts to insert the same validation CNAME record twice is:
Reverting back to 1.1.0 fixed this for me. Is this intended behavior? I must admit that I'm not sure if it makes sense or not to generate the cert for that zone. It could probably be sufficient for the wildcard in my case, but not sure about others.. |
@tareks Yes, the problem you are having is related to the change introduced lately, you can try to specify |
The example in the README also produces this error. :( I just spent at least an hour debugging and trying to filter out duplicate CNAME records but that is close to impossible with Terraform 0.11 :( |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
When creating the following
I get the following error
The module doesn't create the route53 records for each of the SAN domains.
Is this intended and I'm using the module wrong or is this a limitation of the module?
Thanks,
The text was updated successfully, but these errors were encountered: