-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Terra Classic v1.1.0 #348
Conversation
637bf5d
to
42c51e2
Compare
* Update protobuf package for Terra Classic, @terra-money/[email protected], to @classic-terra/[email protected] * Add burn_tax_split to treasury params * Add AddBurnTaxExemptionAddressProposal and RemoveBurnTaxExemptionAddressProposal * Update version of GitHub workflow in the deprecate state
42c51e2
to
59f02f8
Compare
@Jared-TFL you seems to be stating on Twitter that there is something wrong with our PR @ https://twitter.com/ZaradarBH/status/1631696396746145792 . Could anyone in TFL please give us some actual feedback on what the issues are so we can fix them and get the PR approved? Thx. |
Hey, what's the reason to switch to an external npm package for protobuf? |
terra.js is using two version of same npm package '@terra-money/terra.proto' For Terra Classic: https://github.com/terra-money/terra.js/blob/main/package.json#L86 However, there is a protobuf update for Terra Classic v1.1.0 (PR: classic-terra/terra.proto#1) I carefully reviewed all the codes that use legacy.proto (same terra.proto but renamed by npm package feature in package.json) and modified the codes that use legacy.proto unnecessarily to use terra.proto. If you intend to continue maintaining terra-money/terra.proto updates for Classic, I can create a separate PR to terra-money/terra.proto. In this case:
|
Description
This PR adds burn tax split and tax exemption feature to the treasury module to support Terra Classic v1.1.0. This update will solve error on the Station when the Burn Tax Exemption proposal is added to the network.
Changes