Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add vesting token donation feature #88

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

yun-yeo
Copy link

@yun-yeo yun-yeo commented Jun 30, 2022

Description

Implement new interface to donate existing vesting tokens.

MsgDonateAllVestingToken can be executed when there is no delegated vesting token in the from account.

New Codec

In order to enable tx execution with Ledger, the codecs for new message types are added.

cosmos-sdk/MsgCreateVestingAccount
cosmos-sdk/MsgCreatePeriodicVestingAccount
cosmos-sdk/MsgDonateAllVestingTokens


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yun-yeo yun-yeo requested a review from JSHan94 June 30, 2022 07:52
@yun-yeo yun-yeo self-assigned this Jun 30, 2022
@yun-yeo yun-yeo changed the title add vesting token donation feature feature: add vesting token donation feature Jun 30, 2022
@yun-yeo yun-yeo requested a review from JSHan94 July 1, 2022 04:07
@JSHan94
Copy link

JSHan94 commented Jul 1, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants