Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donate all vesting token to work with dust delegations #238

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

javiersuweijie
Copy link
Member

@javiersuweijie javiersuweijie commented Jun 22, 2023

Description

Dust delegation blocks donation of all vesting tokens. This PR adds a fix to clear the dust so that the donation can go through


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@javiersuweijie javiersuweijie force-pushed the fix/donate-all-function branch from 4fae8e6 to a8682bf Compare June 22, 2023 07:38
@emidev98 emidev98 force-pushed the fix/donate-all-function branch from ab46cbe to 48e314f Compare June 22, 2023 08:57
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.46.x@c2d06a0). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release/v0.46.x     #238   +/-   ##
==================================================
  Coverage                   ?   65.48%           
==================================================
  Files                      ?      671           
  Lines                      ?    71478           
  Branches                   ?        0           
==================================================
  Hits                       ?    46805           
  Misses                     ?    22072           
  Partials                   ?     2601           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@emidev98 emidev98 merged commit e2607c0 into release/v0.46.x Jun 22, 2023
@emidev98 emidev98 deleted the fix/donate-all-function branch June 22, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants