Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add a flag to the rest server to accept all cors #420

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 27, 2020

Summary of changes

  • added a flag to the rest server that if you are fine with accepting all cors you can.

close #409

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added enhancement New feature or request devops installation, deployment and node management labels Oct 27, 2020
@yun-yeo yun-yeo requested a review from hanjukim October 27, 2020 06:10
@yun-yeo yun-yeo self-assigned this Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #420 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
- Coverage    67.55%   67.51%   -0.04%     
===========================================
  Files          117      117              
  Lines         5051     5051              
===========================================
- Hits          3412     3410       -2     
- Misses        1426     1427       +1     
- Partials       213      214       +1     
Impacted Files Coverage Δ
x/oracle/tally.go 88.37% <0.00%> (-4.66%) ⬇️

@hanjukim hanjukim merged commit 54ca036 into develop Oct 27, 2020
@hanjukim hanjukim deleted the feature/unsafe-cors-flag branch October 27, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops installation, deployment and node management enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add unsafe-cors flag
2 participants