Update FileData object and scancode executor #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2020 16:22
Give get_file_command the FileData object not the file path within. Signed-off-by: Nisha K <[email protected]>
In order to consolidate file level data collected using different methods, we need some way of consolidating and updating FileData objects. For this, we introduce the merge method to the FileData class. This method will take another FileData class and will replace the properties in the receiving object with the ones in the given object, provided the file path, checksum type and checksum are the same. Here we assume that if a file has the same contents and the same location, it is the same file and the information collected for it is the same. Added appropriate tests for this method. Signed-off-by: Nisha K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work towards #480
The first commit fixes execution of the scancode extension.
The second commit adds a new method to the FileData
class along with a test.
Signed-off-by: Nisha K [email protected]