Integrate scancode data #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2020 13:27
We need the ability to set the file_type after a FileData object is instantiated as we may be able to get that data later. Added a property setter for file_type and a test for the setter. Work towards tern-tools#480 Signed-off-by: Nisha K <[email protected]>
This change uses the FileData class to store all the data scancode collects. There are two scenarios this change tackles: one when tern cannot collect file level data and hence a files list does not exist within the ImageLayer object created during loading the image, and one where tern has processed files in the image but doesn't have any of the other data. In the case where we know the files in the image layer, we introduce a function get_file_command() which will get the correct command to invoke against a file rather than a directory where the file exists. In the analyze_layer() function, if the data retrieved after a scan is a file, a FileData object is created and added to the ImageLayer object. In the case of the analyze_file() function, for each FileData object in the ImageLayer object, we run scancode and fill in the data from the results. This is work towards tern-tools#480 Signed-off-by: Nisha K <[email protected]>
rnjudge
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are work towards #480
The first commit adds a setter for file_type in the
FileData class. The second commit integrates
the scancode data into Tern's data model.
Signed-off-by: Nisha K [email protected]