Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'checksum_type' to checksums #271

Closed
nishakm opened this issue May 15, 2019 · 3 comments · Fixed by #617
Closed

Add 'checksum_type' to checksums #271

nishakm opened this issue May 15, 2019 · 3 comments · Fixed by #617
Assignees
@mukultaneja
Labels
proposal Propose a change to the project super Super issue - other issues are linked to this one technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred
Milestone
Near Future

Comments

@nishakm
Copy link
Contributor

nishakm commented May 15, 2019 •
edited
Loading

Problem Statement
There are other hashing algorithms than SHA256 that tools can use

Describe the Proposal
Incorporate checksum_type into ImageLayer and Image classes

Steps to Implement Proposal

  1. Modify the classes and tests such that there is a checksum_type property and a checksum property. See how the FileData class implements this.
  2. Modify places in the code where SHA256 is hardcoded. Use the checksum_type property instead.
@nishakm nishakm added proposal Propose a change to the project super Super issue - other issues are linked to this one technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred labels May 15, 2019
@nishakm nishakm added this to the Near Future milestone May 15, 2019
@nishakm nishakm modified the milestones: Near Future, Release 0.6.0 Aug 12, 2019
@nishakm nishakm mentioned this issue Aug 29, 2019
Merged
@nishakm nishakm modified the milestones: Release 1.0.0, Near Future Oct 17, 2019
@nishakm nishakm mentioned this issue Oct 18, 2019
Closed
@nishakm nishakm modified the milestones: Near Future, Release 1.1.0 Nov 7, 2019
@nishakm nishakm changed the title Add 'hash_type' to checksums Add 'checksum_type' to checksums Mar 24, 2020
@nishakm nishakm modified the milestones: Release 2.0.0, Near Future Mar 27, 2020
@mukultaneja
Copy link
Contributor

@nishakm, I have submitted a pull request to address this issue 67f8bbe. Please review it. I still need to work on Step 2.

@rnjudge
Copy link
Contributor

rnjudge commented Mar 30, 2020

@nishakm, I have submitted a pull request to address this issue 67f8bbe. Please review it. I still need to work on Step 2.

Can you open this as a separate pull request for this issue? Right now it is appended to PR #616

@mukultaneja mukultaneja mentioned this issue Mar 30, 2020
Merged
@mukultaneja
Copy link
Contributor

mukultaneja commented Mar 30, 2020 •
edited
Loading

Hi @nishakm, @rnjudge I have opened a new PR #617. Please review it.

nishakm pushed a commit that referenced this issue Mar 31, 2020
@mukultaneja
Add ‘checksums’ properties to Image and ImageLayer
d1c846d 
This PR does following,

1. It includes checksum_type and checksum properties
 to Image and ImageLayer classes.
2.It includes appropriate tests to validate the checksum property

Resolved: #271

Signed-off-by: mukultaneja <[email protected]>
rnjudge pushed a commit to rnjudge/tern that referenced this issue Jun 5, 2020
@mukultaneja
Add ‘checksums’ properties to Image and ImageLayer
6aecb41 
This PR does following,

1. It includes checksum_type and checksum properties
 to Image and ImageLayer classes.
2.It includes appropriate tests to validate the checksum property

Resolved: tern-tools#271

Signed-off-by: mukultaneja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukultaneja mukultaneja

Labels
proposal Propose a change to the project super Super issue - other issues are linked to this one technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred
Projects
None yet
Milestone
Near Future
Development

Successfully merging a pull request may close this issue.

Add ‘checksums’ properties to Image and ImageLayer
3 participants
@nishakm @rnjudge @mukultaneja