addpkg(x11/rnote): 0.11.0

[EDLLT]

Fixes #17655

Thanks @Biswa96 @TomJo2000 @Doublonmousse @romanovj @askorbinovaya-kislota and everyone else for your help

[EDLLT]

Seems like it needs tabs for indentation
I need to sleep now, I'll probably fix it tmrw

[TomJo2000]

This looks very close to being done,
I do have a couple housekeeping items we need to take care of though.

---

^{(This is a pre-written, saved reply.)}
Also please make sure to keep your commits squashed.
For adding to a single commit you can use git commit --amend.
Since you already have multiple commits on your branch though,
you'll need to squash those with git rebase -i HEAD~<n> first.
^{(Where <n> is the number of commits you want to modify.
Please make sure to only modify your commits.)}
https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits

Since squashing or amending commits changes the git history you will need to force push any such changes.
e.g. git push --force,
or preferably git push --force-with-lease=branchname
to make sure you aren't clobbering any refs you haven't fetched locally yet.

[TomJo2000]

Almost forgot the most important thing.

A huge thanks to you for your work and contribution.

[TomJo2000]

Missed a couple things on the initial pass.

[TomJo2000]

Alright I have it building locally.
And I've done most of the cleanup I mentioned above.
Will be pushing that shortly.

[TomJo2000]

Alright, I'm gonna go get some sleep, but to recap.

• Build script is cleaned up
• upstream gettext version is synced to our gettext package
• gettext-sys crate version gets automatically fetched from crates.io
• and we're building both the CLI and GUI.

We have a couple non-critical housekeeping items still open, mostly related to PulseAudio support.
And I'd appreciate it if you could do some on-device testing with the CI built rnote package.

To that end;

---

^{(This is a pre-written, saved reply.)}
If you want to test this PR please download the appropriate DEB package(s)
from the build artifacts of the associated PR's latest CI run.

After downloading the build artifact, make sure to unzip and un-tar it.

Detailed instructions, if needed.

# finding out what architecture you need
# architecture is just below the TERMUX_VERSION
termux-info

# e.g.
# [...]
# TERMUX_MAIN_PACKAGE_FORMAT=debian
# TERMUX_VERSION=0.118.0
# TERMUX__USER_ID=0
# Packages CPU architecture:
# aarch64
# [...]

# =======================

# make sure `unzip` and `tar` are installed using
pkg install unzip tar

# unzip the artifact (if you have a different architecture this might be arm, i686 or x86_64 instead)
unzip debs-aarch64-*.zip

# untar the artifact
tar xf debs-aarch64-*.tar

# You should now have a debs/ directory in your current working directory
# Install the packages from the local source using
pkg install -- ./debs/*.deb

# to clean up, you can remove the debs/ directory, .tar file and .zip file
rm -rfi debs debs-aarch64-*.zip debs-aarch64-*.tar

[TomJo2000]

And since the remaining items aren't what I'd consider critical, let me change my review to an approval.

By the way, if you would like to make further contributions on this branch make sure to first rebase your local copy using:

git -c pull.rebase=true pull

[EDLLT]

I think that's about it.
Changed maintainer to me and made gettext work with the patches regardless of its version.
I will now test building locally before squashing everything into one commit

[TomJo2000]

I've removed the now redundant gettext_version variable,
revised the comments in the __fetch_gettext_rs() function
and added committer attribution for Biswa and myself.

You will need to rebase your development branch using git -c pull.rebase=true pull again before making further changes.

Also please make sure to use git push --force-with-lease=rnote when pushing, to not accidentally clobber changes.

[EDLLT]

git push --force-with-lease=rnote

Should I squash everything into one commit now?
I don't think there's anything left and my local build was successful

[TomJo2000]

Should I squash everything into one commit now?

Either you or I can do that, but I think it'd be good practice for you.
Since we have 4 commits that would be git rebase -i HEAD~4.

The rebase queue gets walked through from top to bottom.
So we want to pick the 1st commit, and squash the other 3.

The final commit message should just be:

addpkg(x11/rnote): 0.11.0

Co-authored-by: Biswapriyo Nath <[email protected]>
Co-authored-by: TomIO <[email protected]>

[relma2]

When will this package be merged

[TomJo2000]

Should be good to merge.
I just hadn't gotten around to it.