-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(main/libsqlite): 3.45.3; chore(main/libsqlite-tcl): subpackage of libsqlite #20059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you called me in for a review, doesn't look like I've ever touched the package, but this looks all fine to me, so I'll just leave some observations.
Is it required to configure/make the project twice? |
termux-packages/packages/libsqlite/build.sh Lines 24 to 32 in 1681a6c
We're changing configure options for the second build, so we need to rerun the configure step with the new settings. |
You touched qbittorrent{,-nox} and I stole the idea.
These are two separate projects in the same repo/tarball. But in the case of subpackage we can use automatic updating. |
Touched? I wrote that package build, it hasn't been modified yet. termux-packages/packages/libncnn/build.sh Lines 73 to 79 in 589d25b
|
Answering my own question - it is possible to configure/make once with sqlite-src-xxx.zip file but it requires more changes to the build script. |
Just running the |
Ok, I see nobody minds so I am merging it. |
Closes #20058
I will merge this in 24 hours if no activity.