-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(main): new package esbuild #11895
Conversation
|
https://github.com/evanw/esbuild/blob/3e2374cb011a47482b415f84716afa13ea88f3ce/Makefile#L222 https://github.com/termux/termux-packages/runs/8297765977?check_suite_focus=true#step:6:444 |
That is really weird cause it builds on arm without issues on-device, I don't know what is esbuild doing differently from other packages which termux cross-compiles all the time. |
Can you perhaps try what is mentioned here? golang/go#48246 (comment) Edit: Actually in termux's build context, |
ee47378
to
7469c0f
Compare
CC is not passed in the Makefile, it needs to be set manually. Edit: Same result. |
Really? All other packages that invoke a makefile, never passes
|
1bf9ab0
to
b6cfd1e
Compare
Signed-off-by: 2096779623 <[email protected]> Co-authored-by: Yaksh Bariya <[email protected]>
@2096779623 hi, it's been a while. I tried to look into this and I found something that could be fixed. Try removing the Additionally to clean up the code:
This should hopefully get the arm build fixed and we can move on with this package. |
Closing this because someone else already added the package. |
Close #11873 .