This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
Correct bitmask/bool mixup for STM32 probe pin #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probe_invert is a bool value. Trying to invert its value by xor'ing with a bitmask is prone to fail (dependent on the actual value of the PROBE_BIT bitmask). Fixes non-working tool change operations with e.g. bCNC (which always uses both G38.2 and G38.4).
|
Thanks, I'll merge this as a temporary fix as there are other changes related to probing in the pipeline that I am going to implement across drivers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probe_invert is a bool value. Trying to invert its value by xor'ing with
a bitmask is prone to fail (dependent on the actual value of the
PROBE_BIT bitmask).
Fixes non-working tool change operations with e.g. bCNC (which always
uses both G38.2 and G38.4).