-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API and client improvements and fixes #885
Conversation
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
=========================================
+ Coverage 58.36% 59.4% +1.04%
=========================================
Files 203 203
Lines 9054 9036 -18
Branches 254 254
=========================================
+ Hits 5284 5368 +84
+ Misses 3688 3587 -101
+ Partials 82 81 -1
|
b80498c
to
6016a58
Compare
112f191
to
3fd8d2d
Compare
I am removing WIP, I think it is ready to go, but it should be reviewed by testing locally |
Is the N/A here intentional?
|
@kstaken yes, and no, instead of having a blank value, we put 'N/A' to indicate that this value doesn't exist since applying default values. But your example should show zeros, I will fix that |
@kstaken since you have it up and running can you share the output of
here? |
|
Looks good, thanks @kstaken |
Stopping on
|
That is reporting correct however the job_id I was using was retrieved using |
Using the correct job_id stop works fine but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good.
Resolves #879
Resolves #884
Resolves #880
Resolves #877
Resolves #644