fixed cross cluster searching resolves #692 #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstaken
reviewed
Apr 16, 2018
| if (isWildCardRegexSearch !== null) { | ||
| logger.warn(`Running a regex or cross cluster search for ${opConfig.index}, there is no reliable way to verify index and max_result_window`); | ||
| return Promise.resolve(true); | ||
| } |
There was a problem hiding this comment.
Shouldn't this be in elasticsearch_api with the rest of the logic related to index validation?
|
Unit tests are failing |
|
needs to be used in conjunction with terascope/elasticsearch_api#12 |
|
unit and integration tests pass. Manual xsearch job works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure to specify the correct connection on the job that it points to the node