Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ex/ex_id/slicer api endpoint error resolves #660 #662

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Feb 12, 2018

After testing it seemed that the endpoint works correctly. I got the error reported only when I used the job_id instead of the ex_id for that endpoint. Take note that you can call /jobs/:job_id/slicer with the job_id that is returned assuming you only have one invocation, if you dont you will just get multiple back. If you call /ex/:ex_id/slicer it must be with an actual ex_id, which you would have to dig around a bit. The error was not reporting back correctly so I fixed that

@kstaken
Copy link
Member

kstaken commented Feb 14, 2018

Manually verified.

curl localhost:5678/jobs/3299b2ea-2a56-45ba-85f5-a5ea5df5f798/slicer
[
    {
        "ex_id": "7238d2a3-4cd1-4a1f-b4df-14a80ab8f3d7",
        "job_id": "3299b2ea-2a56-45ba-85f5-a5ea5df5f798",
        "name": "Data Generator",
        "workers_available": 0,
        "workers_active": 1,
        "workers_joined": 1,
        "workers_reconnected": 0,
        "workers_disconnected": 0,
        "failed": 0,
        "subslices": 0,
        "queued": 1,
        "slice_range_expansion": 0,
        "processed": 34,
        "slicers": 1,
        "subslice_by_key": 0,
        "started": "2018-02-14T13:38:01.560-07:00"
    }
]

curl localhost:5678ex/7238d2a3-4cd1-4a1f-b4df-14a80ab8f3d7/slicer
[
    {
        "ex_id": "7238d2a3-4cd1-4a1f-b4df-14a80ab8f3d7",
        "job_id": "3299b2ea-2a56-45ba-85f5-a5ea5df5f798",
        "name": "Data Generator",
        "workers_available": 0,
        "workers_active": 1,
        "workers_joined": 1,
        "workers_reconnected": 0,
        "workers_disconnected": 0,
        "failed": 0,
        "subslices": 0,
        "queued": 1,
        "slice_range_expansion": 0,
        "processed": 40,
        "slicers": 1,
        "subslice_by_key": 0,
        "started": "2018-02-14T13:38:01.560-07:00"
    }
]

@kstaken kstaken merged commit e4851ee into terascope:master Feb 14, 2018
@jsnoble jsnoble deleted the slicer_api_error branch July 5, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants