Worker refactor #661
Merged
Worker refactor #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase |
jsnoble
force-pushed
the
worker_refactor
branch
from
8f1e0ad to
41382e9
Compare
|
Integration tests pass. Manual testing LGTM. |
kstaken
reviewed
Feb 14, 2018
| function terminalShutdown(errEV) { | ||
| logger.error(`Terminal error, shutting down execution ${exId}`); | ||
| events.emit('worker:shutdown'); | ||
| messaging.respond({ message: 'execution:error:terminal', error: errEV.error, ex_id: exId }); |
There was a problem hiding this comment.
I didn't block the merge of this PR for this issue but this message is still incorrectly named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.