Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persitent jobs can return to running resolves #654 #655

Merged
merged 4 commits into from
Feb 14, 2018

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Jan 30, 2018

No description provided.

@kstaken
Copy link
Member

kstaken commented Feb 7, 2018

I can't get this to work. My test involves a data generator -> kafka job where I then stop the kafka cluster and bring it back up. The job goes into failing and stays there. I've tried it both with the default timeout and also setting "probation_window": "10000", with the same results.

Also the setting probation_window is not ideal. Naming this is a tough one but maybe something like failing_recovery_window?

@jsnoble jsnoble force-pushed the persistent_running_executions branch from 1e2dceb to 92fd7ad Compare February 13, 2018 19:12
@kstaken
Copy link
Member

kstaken commented Feb 14, 2018

This needs a rebase.

@jsnoble jsnoble force-pushed the persistent_running_executions branch from 2bd3458 to 768d76e Compare February 14, 2018 21:22
@kstaken
Copy link
Member

kstaken commented Feb 14, 2018

Previously failing manual tests now pass.

@kstaken
Copy link
Member

kstaken commented Feb 14, 2018

Integration and unit tests pass.

@kstaken kstaken merged commit 1f7d086 into terascope:master Feb 14, 2018
@jsnoble jsnoble deleted the persistent_running_executions branch July 5, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants