Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow slices to be sent to specific workers resolves #624 #653

Merged
merged 3 commits into from
Feb 14, 2018

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Jan 25, 2018

this needs changes in the queue module ts-archive/queue#5

@kstaken
Copy link
Member

kstaken commented Feb 8, 2018

Integration tests are failing on this branch. One error was fixed by doing a rebase but I'm still getting this:

Unhandled rejection TypeError: Cannot read property 'workers_joined' of undefined
    at /Users/kstaken/projects/opensource/test/teraslice/integration-tests/spec/wait.js:83:44
    at tryCatcher (/Users/kstaken/projects/opensource/test/teraslice/integration-tests/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/kstaken/projects/opensource/test/teraslice/integration-tests/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/Users/kstaken/projects/opensource/test/teraslice/integration-tests/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/Users/kstaken/projects/opensource/test/teraslice/integration-tests/node_modules/bluebird/js/release/promise.js:614:10)

@jsnoble jsnoble force-pushed the worker_slice_allocation branch from 349a324 to cb694e2 Compare February 13, 2018 19:13
@kstaken
Copy link
Member

kstaken commented Feb 14, 2018

Integration tests require a rebase to master but then pass.

@kstaken kstaken merged commit beb2ac4 into terascope:master Feb 14, 2018
@jsnoble jsnoble deleted the worker_slice_allocation branch July 5, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants