Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teraslice-cli] Fix build:watch command #3877

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[teraslice-cli] Fix build:watch command #3877

merged 5 commits into from
Dec 17, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Dec 13, 2024 •
edited
Loading

This PR makes the following changes:

@sotojn sotojn requested review from jsnoble and busma13 December 13, 2024 23:35
@sotojn sotojn self-assigned this Dec 13, 2024
@sotojn
Copy link
Contributor Author

sotojn commented Dec 13, 2024

I have confirmed all scenarios properly compile changes in the intended way. The following commands have been tested.

Top-level teraslice

  • yarn build
  • yarn build:watch
  • yarn setup

In teraslice-cli

  • yarn build
  • yarn build:watch

busma13
busma13 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busma13 busma13 merged commit cda74ec into master Dec 17, 2024
46 checks passed
@busma13 busma13 deleted the fix-build-watch branch December 17, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@jsnoble jsnoble Awaiting requested review from jsnoble

Assignees

@sotojn sotojn

Labels
bug pkg/teraslice-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotojn @busma13