Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Resolve warnings in tests #3873

Merged
merged 9 commits into from
Dec 17, 2024
Merged

[CI] Resolve warnings in tests #3873

merged 9 commits into from
Dec 17, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Dec 12, 2024

This PR makes the following changes:

@sotojn sotojn self-assigned this Dec 12, 2024
@sotojn sotojn force-pushed the resolve-test-warnings branch from 25d9d00 to 529b966 Compare December 12, 2024 22:58
@sotojn sotojn marked this pull request as ready for review December 13, 2024 23:36
@sotojn sotojn requested review from godber and busma13 December 13, 2024 23:36
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add some more explanation to you PR comment?

@sotojn sotojn force-pushed the resolve-test-warnings branch from 8806b58 to d82cc67 Compare December 17, 2024 17:54
@busma13 busma13 merged commit 53e0d7f into master Dec 17, 2024
47 checks passed
@busma13 busma13 deleted the resolve-test-warnings branch December 17, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants