[teraslice, elasticsearch-store] opensearch2 mappings missing dynamics: false field #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
force-pushed
the
os2-mappings-bug
branch
from
fb218cf to
26e30b5
Compare
…arness doesn't use elasticsearchApi.
godber
reviewed
Oct 25, 2024
packages/elasticsearch-store/src/elasticsearch-client/method-helpers/helper-utils.ts
Show resolved
Hide resolved
busma13
changed the title
busma13
commented
Oct 25, 2024
jsnoble
reviewed
Oct 25, 2024
| it('should have a jobs index with dynamic mapping false', async () => { | ||
| const mapping = await terasliceHarness.client.indices.getMapping({ index: '*__jobs' }); | ||
| const indexName = Object.keys(mapping)[0]; | ||
| const searchVersion = (await terasliceHarness.client.info()).version.number; |
There was a problem hiding this comment.
(await terasliceHarness.client.info()).version.number; is not very readable and its uneeded. The client already has that information on it so there is no need to make the call either through terasliceHarness.client.distributionMeta though the types wont like that or through terasliceHarness.client.__meta
There was a problem hiding this comment.
I didn't know that. Thanks
jsnoble
reviewed
Oct 25, 2024
| @@ -111,5 +111,6 @@ export { | |||
| MINIO_ACCESS_KEY, | |||
| MINIO_SECRET_KEY, | |||
| ENCRYPT_MINIO, | |||
| ROOT_CERT_PATH | |||
| ROOT_CERT_PATH, | |||
| TEST_OPENSEARCH | |||
There was a problem hiding this comment.
you can also pull the version from the enviroment not only just TEST_OPENSEARCH
There was a problem hiding this comment.
For my use case I would need to expose both elasticsearch and opensearch versions, so I'll stick will getting the version from client.__meta.
jsnoble
approved these changes
Oct 25, 2024
godber
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
ensureNoTypeInMapping()to copydynamicproperty when removing type from mapping.method-helpers-spec.tsand adds unit tests forensureNoTypeInMapping().storage-spec.tsto confirm that the jobs state storage index mapping is created withdynamicset tofalse.Ref: #3809