Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-config, data-mate, teraslice] Eslint updates #3796

Merged
merged 4 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"nan": "^2.19.0"
},
"devDependencies": {
"@eslint/js": "^9.10.0",
"@eslint/js": "^9.12.0",
"@swc/core": "1.4.0",
"@swc/jest": "^0.2.36",
"@types/bluebird": "^3.5.42",
Expand All @@ -59,7 +59,7 @@
"@types/lodash": "^4.17.7",
"@types/node": "^18.14.2",
"@types/uuid": "^10.0.0",
"eslint": "^9.10.0",
"eslint": "^9.12.0",
"jest": "^29.7.0",
"jest-extended": "^4.0.2",
"jest-watch-typeahead": "^2.2.2",
Expand Down
10 changes: 7 additions & 3 deletions packages/data-mate/scripts/docs.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import {
toTitleCase, isEmpty, flatten,
flattenDeep, firstToUpper, uniq,
isPlainObject, trimEnd,
isPlainObject, trim, trimEnd,
} from '@terascope/utils';
import { inspect } from 'node:util';
import { functionConfigRepository } from '../dist/src/index.js';
Expand Down Expand Up @@ -126,14 +126,18 @@ function generateAliases(fnDef) {
* @param fnDef {import('..').FunctionDefinitionConfig}
*/
function generateFunctionDoc(fnDef) {
const trimmedDesc = trimEnd(trim(fnDef.description), '.');
const fnDescription = firstToUpper(trimmedDesc)
.split('\n')
.join('\n>');

return [
`
### \`${fnDef.name}\`

**Type:** \`${fnDef.type}\`
${generateAliases(fnDef)}
> ${firstToUpper(trimEnd(fnDef.description.trim(), '.')).split('\n')
.join('\n>')}`.trim(),
> ${fnDescription}`.trim(),
...generateArgDocs(fnDef),
...generateAccepts(fnDef),
...generateExamples(fnDef, fnDef.examples)
Expand Down
2 changes: 1 addition & 1 deletion packages/data-mate/src/data-frame/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function concatColumnsToColumns<T extends Record<string, any>>(
offset: number
): [keyof T, Builder<any>][] {
for (const [field, builder] of builders) {
const col = columns.find(((c) => c.name === field));
const col = columns.find((c) => c.name === field);
if (col) {
for (const [i, v] of col.vector.values()) {
builder.data.set(i + offset, v);
Expand Down
18 changes: 9 additions & 9 deletions packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,23 @@
"test:watch": "ts-scripts test --watch . --"
},
"dependencies": {
"@eslint/compat": "^1.1.1",
"@eslint/js": "^9.10.0",
"@stylistic/eslint-plugin": "^2.8.0",
"@eslint/compat": "^1.2.0",
"@eslint/js": "^9.12.0",
"@stylistic/eslint-plugin": "^2.9.0",
"@types/eslint__js": "^8.42.3",
"@typescript-eslint/eslint-plugin": "^8.5.0",
"@typescript-eslint/parser": "^8.5.0",
"eslint": "^9.10.0",
"eslint-plugin-import": "~2.30.0",
"@typescript-eslint/eslint-plugin": "^8.9.0",
"@typescript-eslint/parser": "^8.9.0",
"eslint": "^9.12.0",
"eslint-plugin-import": "~2.31.0",
"eslint-plugin-jest": "^28.8.3",
"eslint-plugin-jest-dom": "^5.4.0",
"eslint-plugin-jsx-a11y": "^6.10.0",
"eslint-plugin-react": "^7.37.1",
"eslint-plugin-react-hooks": "^4.4.0",
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-testing-library": "^6.3.0",
"globals": "^15.9.0",
"typescript": "^5.2.2",
"typescript-eslint": "^8.5.0"
"typescript-eslint": "^8.9.0"
},
"engines": {
"node": ">=18.18.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ export class NativeClustering {
}

private _notifyNodesWithExecution(exId: string, messageData: any, excludeNode?: string) {
return new Promise(((resolve, reject) => {
return new Promise((resolve, reject) => {
let nodes = this._findNodesForExecution(exId);
if (excludeNode) {
nodes = nodes.filter((node) => node.hostname !== excludeNode);
Expand Down Expand Up @@ -597,7 +597,7 @@ export class NativeClustering {
this.logger.error(error);
reject(error);
});
}));
});
}

readyForAllocation() {
Expand Down
Loading
Loading