Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change docker image to not add "nodevX" if a custom image was provided #3510

Merged
merged 5 commits into from
Jan 2, 2024
Merged

change docker image to not add "nodevX" if a custom image was provided #3510

merged 5 commits into from
Jan 2, 2024

Conversation

lesleydreyer
Copy link
Contributor

@lesleydreyer lesleydreyer commented Dec 21, 2023 •
edited
Loading

  • change docker image to not add "nodevX" if a custom image was provided (DEV_DOCKER_IMAGE)

@lesleydreyer lesleydreyer changed the title WIP make dev image more composable change docker image to not add "nodevX" if a custom image was provided Dec 22, 2023
godber
godber approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work in all the use cases.

@godber godber merged commit 5f65294 into master Jan 2, 2024
39 checks passed
@godber godber deleted the make-dev-docker-image-more-composable branch January 2, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesleydreyer @godber