Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change teraslice-cli tests to use temp dir #3509

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Change teraslice-cli tests to use temp dir #3509

merged 3 commits into from
Jan 2, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Dec 20, 2023

  • Changed tests inside teraslice-cli to use temp directories instead of sharing directories
    • This separates state between tests and guarantee directories even when tests are ran in parallel

This fixes an issue posted here #3494

@sotojn sotojn requested review from godber and busma13 December 20, 2023 23:58
@sotojn sotojn self-assigned this Dec 20, 2023
busma13
busma13 requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new-processor-spec also has directories that are shared. I'm thinking we should take care of that now, before it becomes a problem.

godber
godber previously approved these changes Dec 22, 2023
View reviewed changes
@godber godber dismissed their stale review December 22, 2023 23:30

We should make the changes requested by @busma13

@sotojn
Copy link
Contributor Author

sotojn commented Jan 2, 2024

The new-processor-spec also has directories that are shared. I'm thinking we should take care of that now, before it becomes a problem.

I have updated new-processor-spec.ts to also use temp directories. Great feedback!

@godber godber merged commit 6025bc4 into master Jan 2, 2024
39 checks passed
@godber godber deleted the asset-generator-unit-test-fix branch January 2, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@godber godber godber approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13