Check for orphaned processes by job_id when starting a job #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to native clustering.
…job_id}/_stop endpoint
godber
reviewed
Dec 20, 2023
godber
requested changes
Dec 21, 2023
packages/teraslice/src/lib/cluster/services/cluster/backends/native/index.ts
Outdated
Show resolved
Hide resolved
godber
reviewed
Dec 22, 2023
godber
reviewed
Dec 22, 2023
Co-authored-by: Austin Godber <[email protected]>
godber
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Add check for orphaned resources by job_id before starting job.
Add listResourcesForJobId function to execution service.
Add listResourcesForJobId function to k8s and native cluster backends.
Improve messaging to user when using force option on the POST /jobs/{job_id}/_stop endpoint
Remove check for native clustering when using force stop.
Update docs for _stop endpoint to show an example using force