Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add constant for index required field types #3506

Merged
merged 4 commits into from
Dec 20, 2023
Merged

add constant for index required field types #3506

merged 4 commits into from
Dec 20, 2023

Conversation

lesleydreyer
Copy link
Contributor

@lesleydreyer lesleydreyer commented Dec 19, 2023 •
edited
Loading

  • Add a constant for index required types so packages using es mapping can validate
  • Rework the toESMapping methods to use the above constant
  • bit of tree shaking

@lesleydreyer lesleydreyer changed the title rework toESMapping to validate index w/a constant add constant for index required data types Dec 19, 2023
@lesleydreyer lesleydreyer changed the title add constant for index required data types WIP add constant for index required data types Dec 19, 2023
@lesleydreyer lesleydreyer changed the title WIP add constant for index required data types add constant for index required field types Dec 20, 2023
jsnoble
jsnoble approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit 37cacb5 into master Dec 20, 2023
39 checks passed
@jsnoble jsnoble deleted the datatype-indexed-required-constant branch December 20, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesleydreyer @jsnoble