-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force option to POST /jobs/jobId/_stop and POST /ex/exId/_stop endpoints #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust delete tests to return whole request, not just body.
busma13
commented
Dec 8, 2023
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetes/k8s.ts
Outdated
Show resolved
Hide resolved
godber
approved these changes
Dec 12, 2023
I'm going to merge this, no need to add the comments, perhaps in a later PR. Note, I've bumped the Teraslice version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
force
option to thePOST /jobs/{jobId}/_stop
andPOST /ex/{exId}/_stop
endpointsforce='true'
as a request parameter to forcefully stop all jobs, deployments, replicaSets and pods labeled with the execution ID in the url or the execution ID associated with the jobID in the url.'completed', 'stopped', 'rejected', 'failed', 'terminated', or 'stopping'
to be stopped.delete
job, service, and deployment tests to expect the complete response, not the response.body.Ref: #2670