-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable node 18 tests, remove node 14 tests #3443
Conversation
@jsnoble can you bump the minor version on teraslice in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Jared. I think there are two more places we want to change the node version though:
- In the Dockerfile (
Line 3 in 3300119
ARG NODE_VERSION=14.21.3 - In the ts-scripts helper (
export const NODE_VERSION = process.env.NODE_VERSION || '14.21.3';
Unless you have specific reasons not to change those. The first one certainly needs changing. I haven't thought that hard about the one in ts-scripts.
This PR is the start of the migration away from node 14 and to set node 18 as the primary node version of teralice. Node 18 tests failed due to the got library having a bug in streaming redirects (used in asset processes) so we updated the library to use the ESM version which forces the cut of node 14