Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable node 18 tests, remove node 14 tests #3443

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Oct 20, 2023

This PR is the start of the migration away from node 14 and to set node 18 as the primary node version of teralice. Node 18 tests failed due to the got library having a bug in streaming redirects (used in asset processes) so we updated the library to use the ESM version which forces the cut of node 14

@jsnoble jsnoble requested a review from godber October 23, 2023 17:24
@godber
Copy link
Member

godber commented Oct 23, 2023

@jsnoble can you bump the minor version on teraslice in this PR?

Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Jared. I think there are two more places we want to change the node version though:

Unless you have specific reasons not to change those. The first one certainly needs changing. I haven't thought that hard about the one in ts-scripts.

@godber godber merged commit fa92728 into master Oct 23, 2023
37 checks passed
@godber godber deleted the node-18-e2e-fixes branch October 23, 2023 21:17
@godber godber temporarily deployed to github-pages October 23, 2023 21:31 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants