Add wait for num pods #2074
Merged
Add wait for num pods #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
- Coverage 76.00% 75.80% -0.20%
==========================================
Files 397 397
Lines 15311 15345 +34
Branches 2553 2553
==========================================
- Hits 11637 11633 -4
- Misses 2970 3008 +38
Partials 704 704
|
I also remove the test for the k8s implementation of deleteExecution. Mocking that would be pretty messy.
godber
commented
Jul 28, 2020
packages/teraslice/lib/cluster/services/cluster/backends/kubernetes/k8s.js
Outdated
Show resolved
Hide resolved
|
I have some new changes I intend to make after talking things through with Zach
|
I've added pRetry everywhere but POST. Which should be safe. I now drive the worker pod polling with the default shutdown timeout.
…nto add-waitForNumPods
I also link the worker deployment to the execution controller job. This allows k8s to garbage collect the worker deployment (and then pods) when the execution controller is deleted. This is good in general but also critical to the error handling in deleteExecution closes #1612
|
This is ready for review again. |
Closed
peterdemartini
suggested changes
Jul 31, 2020
packages/teraslice/lib/cluster/services/cluster/backends/kubernetes/utils.js
Outdated
Show resolved
Hide resolved
peterdemartini
approved these changes
Jul 31, 2020
This was referenced Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the teraslice job shutdown process to be more structured. Previously we just "simultaneously" deleted the Worker deloyment and Execution Controller Job, which might leave us with the scenario described here:
#942 (comment)
To mitigate this we now do:
Note that this is in parallel with the other messaging based shutdown activities, those processes would have already been messaged to shut down, this change is a matter of managing the k8s resources (and by virtue of that, the Teraslice processes).