Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s improvments march 2019 #1033

Merged
merged 8 commits into from
Mar 6, 2019
Merged

K8s improvments march 2019 #1033

merged 8 commits into from
Mar 6, 2019

Conversation

godber
Copy link
Member

@godber godber commented Mar 5, 2019

This PR addresses the following things

@godber godber added this to the v0.51.0 milestone Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #1033 into master will decrease coverage by 0.01%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   69.26%   69.25%   -0.02%     
==========================================
  Files         286      286              
  Lines       10302    10307       +5     
  Branches      477      477              
==========================================
+ Hits         7136     7138       +2     
- Misses       3059     3062       +3     
  Partials      107      107
Impacted Files Coverage Δ
...ervices/cluster/backends/kubernetes/k8sResource.js 98.43% <100%> (+0.02%) ⬆️
packages/job-components/src/job-schemas.ts 61.4% <100%> (+0.68%) ⬆️
...luster/services/cluster/backends/kubernetes/k8s.js 55.38% <100%> (ø) ⬆️
...r/services/cluster/backends/kubernetes/k8sState.js 100% <100%> (ø) ⬆️
packages/teraslice/lib/cluster/services/api.js 22.92% <20%> (+0.03%) ⬆️

@godber godber changed the title WIP: K8s improvments march 2019 K8s improvments march 2019 Mar 6, 2019
@godber godber requested a review from peterdemartini March 6, 2019 22:48
@godber godber modified the milestones: v0.51.0, v0.50.0 Mar 6, 2019
@godber
Copy link
Member Author

godber commented Mar 6, 2019

Since I got these done this week, I'm going to move these changes to the v0.50.0 milestone since that's not out yet. @peterdemartini if you can do a quick review ... if it passes without requests for changes, please merge it. If it doesn't, I'll be back monday to address changes and it can go back to v0.51.0.

Copy link
Contributor

@peterdemartini peterdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godber godber merged commit ae43904 into master Mar 6, 2019
@godber godber deleted the k8s-improvments-march-2019 branch March 6, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants