Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Remove duplicate unused unit tests in CI #3858

Closed
sotojn opened this issue Dec 6, 2024 · 0 comments
Closed

[ci] Remove duplicate unused unit tests in CI #3858

sotojn opened this issue Dec 6, 2024 · 0 comments
Assignees
@sotojn
Labels
ci pkg/scripts tests

Comments

@sotojn
Copy link
Contributor

sotojn commented Dec 6, 2024

We have unit tests that don't do anything and take up GitHub runner resources in CI. This is happening because after the change to esm we didn't move the unit-esm tests back to unit-tests.

Here are the problematic tests:
https://github.com/terascope/teraslice/actions/runs/12206075656/job/34054804068
https://github.com/terascope/teraslice/actions/runs/12206075656/job/34054804700
@sotojn sotojn self-assigned this Dec 6, 2024
@sotojn sotojn mentioned this issue Dec 10, 2024
Merged
godber pushed a commit that referenced this issue Dec 10, 2024
@sotojn
[ci, scripts] Remove duplicate unused unit tests in CI (#3866)
c0a6aeb 
This PR makes the following changes:

- Migrates all unit tests from `unit-esm` back to `unit`
- Removes `linux-unit-esm-tests` from ci
- This is no longer needed because all tests have been migrated to
`linux-unit-tests`

Ref to issue #3858
@godber godber closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sotojn sotojn

Labels
ci pkg/scripts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@godber @sotojn