Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change docker-compose command in docker-compose-js #3350

Closed
godber opened this issue Mar 25, 2023 · 2 comments
Closed

Change docker-compose command in docker-compose-js #3350

godber opened this issue Mar 25, 2023 · 2 comments
Assignees
@sotojn
Labels
bug help wanted pkg/docker-compose-js

Comments

@godber
Copy link
Member

godber commented Mar 25, 2023

The docker-compose command has been deprecated and is being removed and replaced with docker compose.

From the end of June 2023 Compose V1 won’t be supported anymore and will be removed from all Docker Desktop versions.

https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command

I'm not sure whether we want to check for docker-compose then docker compose or just switch straight over to the new method. Beyond the change in the name of the command, they have seemed the same, but I haven't really compared explicitly.

https://github.com/terascope/teraslice/blob/master/packages/docker-compose-js/src/index.ts#L65
@godber
Copy link
Member Author

godber commented Dec 5, 2023

Ideally this would try docker compose first, if spawn throws a command not found error (test to see what this is), then try the old way docker-compose, if both fail then tell the user they need to install docker compose.

@sotojn sotojn mentioned this issue Dec 6, 2023
Merged
godber pushed a commit that referenced this issue Dec 7, 2023
@sotojn
update docker-compose-js to use newer 'docker compose' command (#3484)
88aa84a 
- Updated docker-compose-js package to use `docker compose` by default
instead of `docker-compose`
- This is because Compose V1 won’t be supported anymore and will be
removed from all Docker Desktop versions.
- NOTE: `docker-compose` is still backwards compatible if `docker
compose` is not present.
- Bump **packages/docker-compose-js** from `v1.3.1` to `v1.3.2`
- Added user feedback in the event that `docker-compose` or `docker
compose` is not installed.

ref to issue #3350
@godber
Copy link
Member Author

godber commented Dec 15, 2023

Completed

@godber godber closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sotojn sotojn

Labels
bug help wanted pkg/docker-compose-js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@godber @sotojn