Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Metrics still show up in exporter after the job has stopped #2

Closed
godber opened this issue Nov 14, 2020 · 0 comments · Fixed by #3
Closed

Metrics still show up in exporter after the job has stopped #2

godber opened this issue Nov 14, 2020 · 0 comments · Fixed by #3
Assignees
@godber
Labels
bug Something isn't working

Comments

@godber
Copy link
Member

godber commented Nov 14, 2020

I think I need a metricsRegistry.clear() above the following line:

teraslice-exporter/src/metrics.ts

Line 436 in 5fe341d

const globalLabels = {

See:

https://github.com/siimon/prom-client#removing-metrics

Also be aware of:

register.clear() will clear default labels.
@godber godber added the bug Something isn't working label Nov 14, 2020
@godber godber self-assigned this Nov 14, 2020
godber added a commit that referenced this issue Nov 19, 2020
@godber
resetMetrics on update
a1c9c50 
refs #2
@godber godber mentioned this issue Nov 19, 2020
Merged
@godber godber closed this as completed in #3 Nov 19, 2020
godber added a commit that referenced this issue Nov 19, 2020
@godber
Merge pull request #3 from terascope/v0.1.1
e215c41 
This bumps the version for the fix that resolves #2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godber godber

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump version to v0.1.1 terascope/teraslice-exporter
1 participant
@godber