Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows and scripts, make compatible with caching #872

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Update workflows and scripts, make compatible with caching #872

merged 3 commits into from
Jul 31, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jul 26, 2024 •
edited
Loading

This PR makes the following changes:

  • Update workflows pinned hash
  • Update scripts from 0.81.2 to 0.83.1
  • Add docker-limit-check.sh script
  • Add docker related scripts to package.json

@busma13 busma13 marked this pull request as ready for review July 29, 2024 16:10
@busma13 busma13 changed the title Update workflows and scripts Update workflows and scripts, make compatible with caching Jul 29, 2024
@busma13 busma13 requested a review from sotojn July 29, 2024 16:11
sotojn
sotojn approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it wouldn't make sense to add the daily docker cache step I think. Looks good

jsnoble
jsnoble approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit b64580a into master Jul 31, 2024
7 checks passed
@jsnoble jsnoble deleted the update-workflows-and-scripts branch July 31, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotojn sotojn sotojn approved these changes

@jsnoble jsnoble jsnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busma13 @jsnoble @sotojn