Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smaller base docker image without connectors #2

Merged
merged 7 commits into from
Mar 26, 2021
Merged

Add smaller base docker image without connectors #2

merged 7 commits into from
Mar 26, 2021

Conversation

peterdemartini
Copy link
Contributor

@peterdemartini peterdemartini commented Mar 26, 2021 •
edited
Loading

  • Adds a smaller base docker image without the connector, saving 200MB
  • Adds node 14 build
  • Updates node-rdkafka

@godber godber self-requested a review March 26, 2021 20:59
godber
godber approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe in the future we will switch how we do this, but this is a win for now.

@peterdemartini peterdemartini merged commit ffaea01 into master Mar 26, 2021
@godber godber deleted the smaller-docker-image branch July 24, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdemartini @godber