New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace explode with explode_outer #404

Merged

kortemik merged 2 commits into teragrep:main from elliVM:bloom-estimate-explode-outer

Nov 5, 2024

Contributor

elliVM commented Nov 4, 2024

change bloom estimate to use explode_outer

explode() returns only non empty results so rows are lost
explode_outer() returns null that approxCountDistinct() can calculate to return 0


          replace explode with explode_outer

be6de84

elliVM self-assigned this

elliVM requested a review from 51-code

November 4, 2024 10:45

51-code approved these changes

View reviewed changes

Contributor

51-code left a comment

LGTM. Clarification maybe needed: does the test produce an empty tokenizer column because the _raw value is empty in index_Empty?


          rename test and add comments

37e1d75

kortemik approved these changes

View reviewed changes

kortemik merged commit 17f2ce6 into teragrep:main

1 check passed

elliVM mentioned this pull request

teragrep exec bloomfilter create produces no filter for partitions without tokens #402

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet