Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases #38

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Test cases #38

merged 4 commits into from
Nov 26, 2024

Conversation

kortemik
Copy link
Member

No description provided.

Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks overall good but:

Getting these from the com.teragrep.jla_01.RlpLogbackAppenderTest test:

WARN  [IngressImpl] - End of stream for PeerAddress </127.0.0.1> PeerPort <53376>. Closing Connection.
WARN  [IngressImpl] - End of stream for PeerAddress </127.0.0.1> PeerPort <41390>. Closing Connection.

Add test that sends multiple messages and see if everything comes as expected

Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kortemik
Copy link
Member Author

Changes looks overall good but:

Getting these from the com.teragrep.jla_01.RlpLogbackAppenderTest test:

WARN  [IngressImpl] - End of stream for PeerAddress </127.0.0.1> PeerPort <53376>. Closing Connection.
WARN  [IngressImpl] - End of stream for PeerAddress </127.0.0.1> PeerPort <41390>. Closing Connection.

Add test that sends multiple messages and see if everything comes as expected

tcpdump indicates that relp connection is opened twice:

1 open 53 
relp_version=0
relp_software=RLP-01
commands=syslog

1 rsp 86 200 OK
relp_version=0
relp_software=rlp_03,9.0.0,https://teragrep.com
commands=syslog

1 open 53 
relp_version=0
relp_software=RLP-01
commands=syslog

1 rsp 86 200 OK
relp_version=0
relp_software=rlp_03,9.0.0,https://teragrep.com
commands=syslog

2 syslog 75 <12>1 2024-11-26T10:00:12.366Z localhost appName - - - DEBUG logger - none

2 rsp 6 200 OK

3 close 0

3 rsp 0 
0 serverclose 0 

@kortemik
Copy link
Member Author

created #39

@kortemik kortemik merged commit 37853f9 into teragrep:master Nov 26, 2024
1 check passed
@kortemik kortemik deleted the test-cases branch November 26, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants