Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use blf_01 Token inside buffer #12

Merged
merged 4 commits into from
Oct 11, 2023
Merged

use blf_01 Token inside buffer #12

merged 4 commits into from
Oct 11, 2023

Conversation

elliVM
Copy link
Contributor

@elliVM elliVM commented Oct 11, 2023

  • use blf_01.Token inside TokenBuffer
  • return a set of strings without duplicates

@elliVM elliVM self-assigned this Oct 11, 2023
@teragrep teragrep deleted a comment from CLAassistant Oct 11, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ elliVM
✅ kortemik
❌ MoonBow-1
You have signed the CLA already but the status is still pending? Let us recheck it.

kortemik
kortemik approved these changes Oct 11, 2023
View reviewed changes
src/main/scala/com/teragrep/functions/dpf_03/TokenAggregator.scala Outdated
@@ -59,8 +61,10 @@ class TokenAggregator(private final val columnName: String) extends Aggregator[R
override def zero(): TokenBuffer = new TokenBuffer()

override def reduce(b: TokenBuffer, a: Row): TokenBuffer = {
val tokenizer: Tokenizer = new Tokenizer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move new call to zero() and create class private member field for tokenizer (type var);

@kortemik kortemik merged commit 949223a into teragrep:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortemik kortemik kortemik approved these changes

@StrongestNumber9 StrongestNumber9 Awaiting requested review from StrongestNumber9

Assignees

@elliVM elliVM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elliVM @CLAassistant @kortemik @MoonBow-1