Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH#14: add shutdownHook, add initialized boolean to SyslogBridge, remove thr… #53

Merged
merged 1 commit into from
Jan 17, 2025
Merged

GH#14: add shutdownHook, add initialized boolean to SyslogBridge, remove thr… #53

merged 1 commit into from
Jan 17, 2025

Conversation

eemhu
Copy link
Contributor

@eemhu eemhu commented Jan 16, 2025

…ows Exception from close() methods as it was not thrown

Fixes issue:

@eemhu
add shutdownHook, add initialized boolean to SyslogBridge, remove thr…
588f822 
…ows Exception from close() methods as it was not thrown
@eemhu eemhu self-assigned this Jan 16, 2025
@eemhu eemhu requested a review from MoonBow-1 January 16, 2025 10:43
MoonBow-1
MoonBow-1 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@MoonBow-1 MoonBow-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@eemhu eemhu requested a review from kortemik January 16, 2025 11:49
@kortemik
Copy link
Member

kortemik commented Jan 16, 2025 via email

@kortemik kortemik merged commit 1e1b500 into teragrep:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonBow-1 MoonBow-1 MoonBow-1 approved these changes

@kortemik kortemik kortemik approved these changes

Assignees

@eemhu eemhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eemhu @kortemik @MoonBow-1