-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should implement project specific config support feature #321
Comments
…fic config support feature
…fic config support feature
…fic config support feature
…fic config support feature
6ac70b3 teracyhq#321 teracyhq#314 teracyhq#302 should implement project specific config support feature
…fic config support feature teracyhq#326
…fic config support feature teracyhq#326
let me check and improve minor things. |
@phuonglm bug detected:
when $ vagrant sync-back not from acme-dev but with deeper folder level. |
@phuonglm I've updated the following branches that use the develop branch of teracy-dev for test the real use case of this feature:
And I think that we should allow missing project config (just warning instead of fatal and exit), for example, from: https://github.com/acme101/dev-setup/blob/develop/vagrant_config_default.json#L5-L6 By that, users don't have to touch or override any configs, it should just work. What do you think? |
there is one use case in the future that teracy-dev will be splinted into a separated project (teracy-dev-setup that should have the same project layout with other projects and it should be configured as follows: {
"vagrant": {
"config_paths": [ // add paths of json config files to be loaded
// the path must be relative to the Vagrantfile
"workspace/teracy-dev-setup/vagrant_config_default.json",
"workspace/angular-hello-world/dev-setup/vagrant_config_default.json",
"workspace/nextjs-hello-world/dev-setup/vagrant_config_default.json"
]
}
} that's it. It's the proof of the future compatibility 💃 |
no more problems detected so far, so @phuonglm please check my comments above and fix, improve things. |
should implement project specific config support feature #321; fix bug
works as expected, closed now. |
reopened as there is bug: "override.json" instead of "overide.json" |
…ture: override instead of overide
…ture: override instead of overide
…nfig-support @ #321 | should implement project specific config support feature: override instead of overide
everything should work now, closed. |
spec from #315
The text was updated successfully, but these errors were encountered: