Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should support for vagrant plugin config settings #186

Closed
hoatle opened this issue Dec 9, 2016 · 5 comments
Closed

should support for vagrant plugin config settings #186

hoatle opened this issue Dec 9, 2016 · 5 comments

Comments

@hoatle
Copy link
Member

hoatle commented Dec 9, 2016

there are cases that we need to add additional vagrant config, usually when use more custom plugins.

We should not edit Vagrantfile directly but use vagrant_config.json instead (of course, override-able by vagrant_config_override.json, too)

plugins config section like:

{
  "plugins": {
    "vagrant-gatling-rsync": {
      "config_key": "gatling",
      "required": true,
      // auto rsync watch when up/ reload done
      // should try to reduce rsync latency to 0.5s instead of 1s #173
      "latency": 0.5, //0.5s
      "rsync_on_startup": true
    },
    "vagrant-rsync-back": {
      "required": true
    }
  }
}
@hoatle hoatle added the feature label Dec 9, 2016
@hoatle hoatle added this to the v0.5.0 milestone Dec 9, 2016
@hoatle hoatle self-assigned this Dec 9, 2016
hoatle added a commit to hoatle/teracy-dev that referenced this issue Dec 10, 2016
@hoatle
Copy link
Member Author

hoatle commented Dec 10, 2016

this is not easy as I haven't figured out how to set plugin config dynamically.

The current WIP branch: https://github.com/hoatle/teracy-dev/tree/features/186-plugins-settings

hoatle added a commit that referenced this issue Dec 10, 2016
… plugins checking temporarily to use new plugins config settings format
@hoatle
Copy link
Member Author

hoatle commented Dec 10, 2016

I've merged as incomplete implementation:

  • use plugins config format

but temporarily use fixed plugin checking. Need to work on this to get it dynamic.

@hoatle hoatle removed their assignment Dec 10, 2016
hoatle added a commit that referenced this issue Dec 10, 2016
…ng vagrant-gatling-rsync time_format config
hoatle added a commit that referenced this issue Dec 10, 2016
@hoatle hoatle modified the milestones: v0.5.0, v0.5.0-b1 Jan 23, 2017
@hoatle
Copy link
Member Author

hoatle commented Feb 7, 2017

related to #239

@hoatle
Copy link
Member Author

hoatle commented Feb 8, 2017

new plugin config format from #239

  "plugins": [{
    "_id": "0",
    "name": "vagrant-gatling-rsync",
    "config_key": "gatling",
    "required": true,
    // auto rsync watch when up/ reload done
    // should try to reduce rsync latency to 0.5s instead of 1s #173
    "latency": 0.5, //0.5s
    "time_format": "%H:%M:%S",
    "rsync_on_startup": true
  }, {
    "_id": "1",
    "name": "vagrant-rsync-back",
    "required": true
  }]

@hoatle
Copy link
Member Author

hoatle commented Feb 12, 2017

#246 should help to customize other vagrant plugins now, though, it's not the most convenient way (just json config is enough)

@hoatle hoatle modified the milestones: v0.6.0, v0.5.0 Jun 23, 2017
@hoatle hoatle modified the milestones: v0.5.0-c2-dev, v0.6.0-dev Jul 24, 2017
@hoatle hoatle assigned ducng0610 and unassigned phuonglm Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants