Refactor GeneralizedRotation to generators with (possible) nullspace.
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariavh
commented
Sep 20, 2023
dariavh
changed the title
GeneralizedRotation to generators with nullspace (P0).GeneralizedRotation to generators with (possible) nullspace.
kottmanj
reviewed
Sep 21, 2023
src/tequila/circuit/gates.py
Outdated
| @@ -1056,14 +1052,13 @@ def __init__(self, angle, target, generator=None, p0=None, assume_real=True, con | |||
| assert generator is not None | |||
| assert p0 is not None | |||
|
|
|||
| super().__init__(name="QubitExcitation", parameter=angle, target=target, control=control) | |||
| self.generator = generator | |||
| if control is not None: | |||
There was a problem hiding this comment.
This part needs to go to the parent class (GeneralizedRotationImpl) as this modification of p0,in case a controlled gate is initialized, needs to happen there as well
There was a problem hiding this comment.
Done, thanks for the comment!
kottmanj
reviewed
Sep 21, 2023
kottmanj
reviewed
Sep 21, 2023
|
It looks good so far. I think I found the reasons for the failed tests (see comments). |
kottmanj
reviewed
Sep 21, 2023
|
@kottmanj Additional remark: The |
…riavh/tequila into refactor/generalized_rotation
…for SWAP and GenRot
|
Looks ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jakob,
Following our discussion about the
GeneralizedRotationgate, I have transferred theshifted_gatesfunctionality fromQubitExcitationtoGeneralizedRotation. This modification allows theGeneralizedRotationmethod to accept generators that do not necessarily have only two eigenvalues of +-r.